Invalid encoding in XML save string
Closed this issue · 5 comments
When calling getSaveString() on the WorkspaceController, the XML string is filled with the ISO-8859 encoding which is not valid, it should be ISO-8859-1.
On a side note, why have ISO-8859-1 in the first place? Wouldn't UTF-8 make more sense since all Java strings use this encoding already?
I've created a fork and adapted the code there.
Is the current way of storing state even at all desireable?
Good point, I would have rather created a DOM that would be serialized in the getSaveString method. Is the save_format.dtd up to date at all? How about replacing it with a schema instead? Also it would be nice if there was a namespace since we're including the blocks in another XML.
AFAIK the original authors of the project have long since ceased their maintenance, and anybody who wants to define objectives for saving state, and then provide a good quality implementation, has a free hand to express themselves.
Whether it's XML/XSD, YAML, or JSON, doesn't really matter very much to me, as long as the changes make the software simpler.
Did you solve this problem to your satisfaction?
oh yes, works for me know