Is Pdf component a part of official API?

Question

Is Pdf component a part of official API?

Closed this issue 5 years ago · 4 comments

Only usePdf is mentioned in the readme. Pdf component being the default export of the module is not. It should either be documented or removed.

Answer 1 · 2019-12-30T17:09:43.000Z

Agreed, I left it in to make the transition to our new hooks API easier. We should make this decision one day soon. Which way would you go?

Answer 2 · 2019-12-30T19:26:03.000Z

I would leave it, but change the existing api to allow passing props to the canvas. Either way, changing or removing it will cause a major version bump.

I can prepare a PR with the changes as I would see them.

Answer 3 · 2019-12-30T20:20:04.000Z

I've prepared a PR that can be treated as entry point to bigger refactor. #182
A discussion about how to proceed and what to add/remove would be nice.

Answer 4 · 2020-01-02T19:55:25.000Z

Created additional PR #183 with further changes.