Weird box beside check issue
Braunson opened this issue · 10 comments
Just updated to latest, now when running tests there's a box that appears beside each check icon..
SSHing into Homestead via SmarTTY on Win 10, didn't have this issue previously.
Hmmm, curious. It is some escape character for sure. I have a few ideas, but will take a closer look using your environment.
@Braunson Does this happen with other icons, or is it just pass?
Can you please try editing the phpunit-printer.yml file and change the marker for cd-pass and see what happens.
In addition, try remove all the whitespace in this file as well and test. I am curious if there is something in the whitespace that is being identitied on your homestead vm.
options:
cd-printer-hide-class: false
cd-printer-simple-output: false
cd-printer-show-config: true
cd-printer-hide-namespace: true
cd-printer-anybar: false
cd-printer-anybar-port: 1738
markers:
cd-pass: "✔︎ "
cd-fail: "✖ "
cd-error: "⚈ "
cd-skipped: "=> "
cd-incomplete: "∅ "
cd-risky: "⌽ "What version of OS (assuming Ubuntu) and PHPUnit are you using.
I have tested across all our test environments (various versions of Ubuntu and PHPUnit) using docker and I am not seeing the box character
@Braunson In the latest version, the pass icon is different that previous builds. Here is what they used to use if you would like to take this cd-pass icon and place in your local phpunit-printer.yml
...
markers:
cd-pass: "✓ "
cd-fail: "✖ "
cd-error: "⚈ "
cd-skipped: "=> "
cd-incomplete: "∅ "
cd-risky: "⌽ "
...Note: In some Environments like Travis, Jenkins or some old Bash Console the UTF-8 Characters ✘ and ✔ are not supported, thus I believe the change to the cd-pass marker may be the issue.
Therefore, if you change to the previous cd-pass marker using the above, I think this will solve the issue fo you.
Running Ubuntu 18.04.1 LTS
Changing the cd-pass icon fixes it solves it.
Still very weird the strong checkmark \u2714 causes this.
Hmm, I did copy the U+2714 heavy checkmark ✔ from another place and pasted it into the phpunit-printer.yml file and it shows the heavy checkmark without the box. I did take your default .yml file strong checkmark and checked for hidden chars but didn't find anything. A very weird issue.
This is the contents of my phpunit-printer.yml file that work (still with the strong checkmark) but without the block following it:
options:
cd-printer-hide-class: false
cd-printer-simple-output: false
cd-printer-show-config: true
cd-printer-hide-namespace: true
cd-printer-anybar: false
cd-printer-anybar-port: 1738
markers:
cd-pass: "✔ "
cd-fail: "✖ "
cd-error: "⚈ "
cd-skipped: "=> "
cd-incomplete: "∅ "
cd-risky: "⌽ "
Well, glad that you have it resolved. I will take your updated hard checkmark from above and update the source to use it and get an update released so this will be cured for the masses.
@Braunson I have tagged a new version 0.26.2, now available on packagist. When you have a chance, can you please test the release version and make sure it is working correctly.
@mikeerickson Yep solved in the new release for me! Thanks!
@Braunson Awesome, thanks for helping debug the issue.