mikehardy/jetifier

react-native-firebase doubt

matamicen opened this issue · 1 comments

Hi @mikehardy @matt-oakes

I have a doubt, after executing npx jetify is solves all the problems of react-native-firebase and everything is working ok but in the gradle library i saw this line which I suspect isnt compatible with androidX ?

...
// For React Native Firebase Notifications
  api "com.android.support:support-v4:$supportVersion"
...

it suppose that I have to change this manually? or I am missing something ?

Again: besides this line everything seems to work okay.

Thanks for your support to the community.

Matt.

Probably item 2 here https://github.com/mikehardy/jetifier#module-maintainers

But in general I believe the Android Studio / Gradle java-level jetifier library will transform the library references correctly