mikekelly/hal-browser

Why is .gitignore excluding html files

arichiardi opened this issue · 2 comments

Hello folks,

I was trying to use this package along with another couple of our things and I have noticed that npm did not include the two files browser.html and login.html in the deployed version.
I then came here and noticed that they are excluded by .gitignore and unfortunately npm does consider that when deploying.

So what I wanted to ask really is whether we could remove the line from .gitignore or (more likely) there is a super valid reason not to do so 😄.

Thanks for this package @mikekelly, it is super useful!

Hello! Any suggestion on how to solve this?

I solved by explicitely using the files key in my package.json.