Issue in algorithm for convert time from Decimal to calendar

Question

Issue in algorithm for convert time from Decimal to calendar

Closed this issue 12 years ago · 3 comments

If local time variable will be less then 0, in method SolarEventCalculator.getLocalTimeAsCalendar(), result will be incorrect.

Answer 1 · 2012-05-08T13:57:20.000Z

Thanks for reporting this.

Do you have a use case for the error? I can duplicate it in a unit test but can't replicate the condition using real-world test data.

Answer 2 · 2012-05-08T14:11:18.000Z

I found this issue when I tried to calculate official sunrise time for my place (Novosibirsk, Russia) yesterday.
latitude = 55.03
longitude = 82.91
date = 07 may 2012
correct sunrise time is 22:35 GMT

Answer 3 · 2012-05-09T00:12:25.000Z

The latest commit fixes this issue.

-Mike