mikereedell/sunrisesunsetlib-java

Current tests failed

Opened this issue · 4 comments

Failed tests:
testRiseAndSetTimes(com.luckycatlabs.sunrisesunset.SunriseSunsetDataTest): Expected: 04:48, but was: 05:48 for date: 4/06/2008

Can you fix it? I want to use your lib

What are the latitude/longitude coordinates you are using in the computation?

I'm just running the tests with maven so If it does not fail for you it must be because your tests vary on user timezone. but it shouldn't.

I'm in Paris, so i'm running it with GMT+1

The tests indeed pass for me so they must be relying on the systems timezone. I'll get a fix in as soon as possible.

I changed my mac to be in the CET timezone and the tests still run. What version of java are you using? Post the full output of java --version if you can. The timezone databases in the JVM get updated quite often.