Source versioning
fabaff opened this issue · 4 comments
The release overview says pysmb 1.2.2 and the setup.py file uses also 1.2.2 (version = "1.2.2",) but the source tarball is named rel-1-2-2.tar.gz. This adds additional work for distribution packager and can cause other issues.
Please consider to name the source tarballs according the used versioning schema, e.g., pysmb-1.2.2.tar.gz. Thanks
Most users use pip to install pysmb. I don't think they use github source tarball directly.
Can you elaborate further on the "additional work for distribution packager" and what are the "other issues" involving with the naming of the source tarball on github?
Most users use pip to install pysmb. I don't think they use github source tarball directly.
Users not but packagers do.
The spec file for RPM packages is deriving various parts for the used macros from already present definitions. E.g, Version: 1.2.2 is used to generate the URL to download the source %{url}/archive/v%{version}/%{pypi_name}-%{version}.tar.gz as the %{version} contains the version that is used across the file and for naming the output file. Something like rel-1-2-2 can be derived. It has to be manually edited for all updates if there is no sed involved.
One major issue is that packagers can't switch without interventions between the source from PyPI and GitHub if a new release doesn't contains all files or a like. Ok, that's not possible currently anyways as the GitHub source is a tarball and the source from PyPI a zip archive ;-)
Thanks for your insights. I will change the tag name format in the next pysmb release.
Adopt new tag name format, starting from pysmb 1.2.3