mikexstudios/python-firebase

__request() method is returning r.json instead of r.json()

espeed opened this issue · 1 comments

The __request() method is returning r.json instead of r.json()...

https://github.com/mikexstudios/python-firebase/blob/master/firebase/__init__.py#L89

The Firebase API endpoints end in .json (https://www.firebase.com/docs/rest-api.html), but __request is returning the Python requests module json method with invoking it.

Is that what's intended?

Hey James, thanks for reporting this issue! The problem was that the requests library changed how json responses were handled, i.e. kennethreitz/requests@fe0b0a9

So I updated .json to .json() and specified explicit version dependency on the requests library.