mikkel-ol/vsc-er-syntax-highlighting

Node modules are not installed on downloaded

user-name-is-taken opened this issue · 1 comments

Here are the files that are downloaded to my machine when I install the extension. No node modules are included:

~/.vscode/extensions/mikkel-ol.er-syntax-highlighting-0.6.0$ ls -al
total 604
drwxrwxr-x  4 user user   4096 Jan 19 21:12 .
drwxrwxr-x 62 user user   4096 Jan 19 17:02 ..
-rw-r--r--  1 user user    854 Jan 19 16:12 example.er
-rw-r--r--  1 user user 189585 Jan 19 16:12 example.png
-rw-r--r--  1 user user    192 Jan 19 16:12 .gitignore
-rw-r--r--  1 user user  51598 Jan 19 16:12 icon.png
-rw-r--r--  1 user user 303206 Jan 19 16:12 icon.psd
-rw-r--r--  1 user user   1316 Jan 19 17:21 index.js
-rw-r--r--  1 user user    661 Jan 19 16:12 language-configuration.json
-rw-r--r--  1 user user   1074 Jan 19 16:12 LICENSE.txt
-rw-r--r--  1 user user   1572 Jan 19 16:12 package.json
-rw-r--r--  1 user user  12288 Jan 19 21:12 .package.json.swp
-rw-rw-r--  1 user user   1036 Jan 19 16:12 README.md
drwxrwxr-x  2 user user   4096 Jan 19 16:12 syntaxes
-rw-r--r--  1 user user    506 Jan 19 16:12 test.er
drwxrwxr-x  2 user user   4096 Jan 19 16:12 .vscode
-rw-rw-r--  1 michael michael   2250 Jan 19 16:12 .vsixmanifest

It may be that you did not package them when publishing the extension (https://code.visualstudio.com/api/working-with-extensions/publishing-extension). This might be solved by later versions of vsce (microsoft/vscode-vsce#100). An alternative hacky fix for this could be to have npm install . run on the user's machine when they install the extension.

Publishing extensions should not include node_modules.

VS Code handles installation of dependencies itself. If you are experiencing problems installing the extension, I would suspect a problem with VS Code.