mila-iqia/SARC

GPU type not saved if statistics already saved.

Opened this issue · 0 comments

for entry in tqdm(scraper):
    saved = False
    if not ignore_statistics:
        saved = entry.statistics(recompute=True, save=True) is not None

    # Get GPU info for this job.
    update_allocated_gpu_type(cluster, entry)

    if not saved:
        collection.save_job(entry)
print(f"Saved {len(scraper)} entries.")

The part collection.save_job(entry) will not be called if entry.statistics returns True. The function update_allocated_gpu_type should also verify if it had made any modification and return this as a bool.