mila-iqia/atari-representation-learning

unused naff_fc_size parameter

AnxietyYoungPoet opened this issue · 2 comments

self.fc_layers = nn.Sequential(
nn.Linear(in_features=self.feature_size,
out_features=self.feature_size))

In NaFFPredictor, the fc layer uses the feature_size from the encoder as the layer width, hence the naff_fc_size is left unused. Also, Sequential is used here, so it seems there might be multiple layers.

Oh good catch! I believe it was initially used, but then we realized to make the capacity the same as the VAE, the "middle" FC layer could only be a feature_size x feature_size matrix. We'll remove that argument

@eracah Got it! Thanks for your clarification!