Cask sudo prompt uses GPGTools logo

[mologie]

Hi, I received the following prompt when attempting to install Microsoft Teams through Applite:

The lock logo is from the https://gpgtools.org/ project, and I was /super/ confused by this because I first thought it prompted for my GPG keychain passphrase, which was of course unexpected.

If anything this should pop up an Apple system authorization dialog, and if a custom one is not avoidable it should not use icons from unrelated projects, copyright issues aside.

[milanvarady]

Hi, you were prompted for your admin password because Microsoft Teams has a .pkg installer which requires it. We need to pass the password into the running brew shell instance through the 'SUDO_ASKPASS' parameter, and given that Applite is a GUI focused app we needed a graphical solution. The default apple password prompt unfortunately cannot be used through the command line, so we ended up using the pinentry-mac package, which is part of GPGTools. It is the most secure way we found to pass the password into the shell. See #5 for more info.

[mologie]

Hi, thanks for the explanation and super-quick response. Using pinentry-mac explains the icon to me, however this totally explains my reaction too: I so far saw GPGTools' pinentry on macOS only when being prompted for GPG stuff so far, and this is not GPG stuff.

Up to you of course whether you want to address this but I was confused as reasonably technical user, and hence made the bug report. If you compile pinentry-mac for Applite anyway you can probably just replace the logo with your own.

Thanks for considering and making Applite!

[milanvarady]

Thanks for letting me know. I'll close the issue for now.