[2.0] Use symbols for instance checks

Question

[2.0] Use symbols for instance checks

milesj opened this issue 6 years ago · 1 comments

Right now our instance checks us instanceof and constructor name comparison as a fallback. This is obviously very brittle, so let's move to symbols and Symbol.hasInstance checks. This wouldn't be a breaking change if it weren't for Tool#registerPlugin, which will now require a unique symbol to be passed.

Answer 1 · 2020-06-22T00:42:41.000Z

Core is being deprecated in v2, so this isn't necessary. However, the new plugin package uses a different approach.