milesj/packemon

Bug: types not added to export map for tsx input files

wespickett opened this issue · 3 comments

https://github.com/wespickett/packemon-test2

Steps:
npm install
cd packages/example1
npm run build

cd ../..
npm run fix

Repeat steps 2-3

Expected:

 "exports": {
    "./package.json": "./package.json",
    "./otherweb": {
      "node": {
        "types": "./lib/node/web.d.ts",
        "default": "./lib/node/node/web.js"
      },
      "default": "./lib/node/node/web.js"
    },
    "./web": {
      "browser": {
        "types": "./esm/browser/index.d.ts",
        "module": "./esm/web.js",
        "import": "./esm/web.js"
      }
    },
    ".": {
      "react-native": {
        "types": "./lib/node/index.d.ts",
        "default": "./lib/native/index.js"
      },
      "default": "./lib/native/index.js"
    }
  }

Actual:

"exports": {
    "./package.json": "./package.json",
    "./otherweb": {
      "node": "./lib/node/node/web.js",
      "default": "./lib/node/node/web.js"
    },
    "./web": {
      "browser": {
        "module": "./esm/web.js",
        "import": "./esm/web.js"
      }
    },
    ".": {
      "react-native": {
        "types": "./lib/native/node/index.d.ts",
        "default": "./lib/native/index.js"
      },
      "default": "./lib/native/index.js"
    }
  }

Possible fix: https://github.com/wespickett/packemon-test2/blob/main/fix.patch

milesj commented

@wespickett Released a new version, let me know if theres still issues.

@wespickett Released a new version, let me know if theres still issues.

Updated to the new version and everything seems to be working now, thanks @milesj

milesj commented

Awesome, thanks for the help