milkytracker/MilkyTracker

MIDI support no longer optional

Closed this issue · 2 comments

Logged via IRC:

<plasma41> MIDI support in milkytracker was mistakenly made non-optional by commit f578adf. The addition of the REQUIRED keyword of the find_package() command results in the 'else' codepath in the following 'if' conditional never being reached.

Thank you very much for logging this.

find_package(RTMIDI "2.1.0" REQUIRED) # 2.1.0 and above

OK I guess REQUIRED does not mean '2.1.0' and above.
Should look up the CMAKE docs to do this properly.

Fixed in 50273e4