milvus-io/milvus-sdk-java

[Proposal] Changing log level to capture requestParam

Closed this issue · 1 comments

vsanna commented

Related PR: #724

Context

  • AbstractMilvusGrpcClient captures requestParam and (method names) in logs as INFO level, which is the default log level of this lib
  • That causes applications that use this lib to generate a large amount of logs with default settings.
    • Of course, we can change log level to DEBUG by calling setLogLevel though.
  • Also, in my opinion, capturing parameters is a little bit overkilling as INFO level as considering this is a library. That should be decided by the users of this lib.
  • I'd like to ask if milvus team would change the log level to capture requestParam from INFO to DEBUG.
vsanna commented

The proposal PR was merged. Let me close this PR.
Thanks!