MIME::Types[/regex/]: Exception thrown for unmatched regex

[TheDeepestSpace]

MIME::Types[/regex_that_wont_match/]
=> NoMethodError: undefined method `sort' for nil:NilClass
        from /var/lib/gems/2.3.0/gems/mime-types-3.1/lib/mime/types.rb:132:in `[]'
        from /var/lib/gems/2.3.0/gems/mime-types-3.1/lib/mime/types/registry.rb:13:in `[]'
    ...

looks like match function returns nil when no matches were found:

ruby-mime-types/lib/mime/types.rb

Lines 216 to 220 in 8de8dbb

	def match(pattern)
	@type_variants.select { |k, _|
	k =~ pattern
	}.values.inject(:+)
	end

to be more specific:

[].inject(:+)
=> nil

nil value then gets assigned to matches variable:

ruby-mime-types/lib/mime/types.rb

Lines 123 to 134 in 8de8dbb

	matches = case type_id
	when MIME::Type
	@type_variants[type_id.simplified]
	when Regexp
	match(type_id)
	else
	@type_variants[MIME::Type.simplified(type_id)]
	end
	prune_matches(matches, complete, registered).sort { |a, b|
	a.priority_compare(b)
	}

then matches gets passed to prune_matches function, that would also return nil if matches parameter is set to nil:

ruby-mime-types/lib/mime/types.rb

Lines 210 to 214 in 8de8dbb

	def prune_matches(matches, complete, registered)
	matches.delete_if { |e| !e.complete? } if complete
	matches.delete_if { |e| !e.registered? } if registered
	matches
	end

a sort function is called on the returned nil, producing the error here:

ruby-mime-types/lib/mime/types.rb

Line 132 in 8de8dbb

prune_matches(matches, complete, registered).sort { |a, b|

[halostatue]

Related to #117 and #127.

[halostatue]

Resolved with edf3cd7.