mindearth/mobilkit

Installation

Closed this issue · 3 comments

levisweetbreu commented

@takayabe0505 I am reviewing mobilkit for submission to JOSS, and I have a few notes about installation.

  1. Adding instructions or a link for Dask installation would be helpful to users.
  2. It would be useful to include installation instructions for all operating systems. I use Windows and had to do a few extra and different steps than what is listed in the documentation.
  3. When testing the mobilkit install in python, I got an error message AttributeError: module 'pandas.core.strings' has no attribute 'StringMethods' and I had to run the command pip install --upgrade pandas "dask[complete]" to solve the issue and address the importation error. I'm not sure if this was an issue with my Dask installation or the mobilkit installation but it would be useful to look into.

openjournals/joss-reviews#5201

ubi15 commented

Hi @levisweetbreu:

  1. ok, will add the link to Dask installation in the README and documentation;
  2. We do not have a Windows machine to test on, could you briefly summarize the extra steps you had to go through to have it running?
  3. Probably it was a Pandas/Dask version mismatch. We rely on a specific Dask version (dask[full]==2022.4.1) as we encountered some bugs in the groupby functions in the following versions. I will update the requirements.txt file to mirror this issue.

Will implement these changes as soon as I have time and mention this issue in the commit.

Thanks for your inputs and let me know if you have other comments.

levisweetbreu commented

@ubi15 the Windows instructions just have a little different syntax:

python -m c:\path\to\mobilkit to create the virtual environment;
mobilkit\Scripts\activate.bat to activate the virtual environment from the command line.

Once the changes are made I'll close this issue and check off the installation box!

ubi15 commented

Hi @levisweetbreu I did the following in 71a548c and 8d65cf9:

  1. Actually the separate Dask installation was not needed, changed the text accordingly;
  2. Added the Windows instructions, let me know if I got your suggestions right;
  3. Updated the requirements.txt even though they are not used by the packaging system and updated Dask and Pandas to avoid that issue.

I will later release the 0.2.7 versions including these changes if you do not see other issues.