Emscripten?

Is it supported? There is enough Emscripten-specific code but no traces of autobuild or testing. I don’t want to keep the code blindly, not knowing whether I broke it inadvertently. There should either be a way to build and test it, or it should be eliminated, IMO.

There's an unofficial web version of Minetest at https://minetest.dustlabs.io/
@paradust7: would it help to keep the code, and can you test/maintain it?

I haven't contributed anything upstream, all my changes are in my forks at https://github.com/paradust7.

Irrlicht already came with Emscripten support, but I had to replace portions of it, because not all of it was in working condition anyway. If you point me to specific sections, I can comment on it. The OpenGLES driver is the essential part.

Don't worry too much about breaking it. When I pull and update (generally once every 3-4 months), I fix any new bugs or compile errors. But if you were to delete entire sections needed for Emscripten, I'd have to restore them in the fork.

Thanks. I’ll try to avoid excessive breakage, but expect some code flux. I’m working on new OpenGL drivers, including a ES 2 driver; see #160 for the details. The current code (#167) is incompatible with WebGL AFAIK but the OpenGL 3 Core driver I plan should be better (in the core profile, vertex and index data may only come from buffers, and also VAOs are mandatory; to my understanding, these are also the restrictions WebGL adds to GLES).

One specific thing that seems strange for me is that SDL_CreateWindowAndRenderer seems to be called twice if window size is set to zero in CreationParams, first time from createWindow:

irrlicht/source/Irrlicht/CIrrDeviceSDL.cpp

Line 392 in 5a79e1a

    
           SDL_CreateWindowAndRendererFixed(Width, Height, SDL_Flags, &Window, &Renderer); // 0,0 will use the canvas size

And second time from createDriver:

irrlicht/source/Irrlicht/CIrrDeviceSDL.cpp

Lines 541 to 544 in 5a79e1a

    
           	if ( VideoDriver && CreationParams.WindowSize.Width == 0 && CreationParams.WindowSize.Height == 0 && Width > 0 && Height > 0 ) 
        
           	{ 
        
           #ifdef _IRR_EMSCRIPTEN_PLATFORM_ 
        
           		SDL_CreateWindowAndRendererFixed(Width, Height, SDL_Flags, &Window, &Renderer);

That branch is never actually taken on other platforms IIUC.

	if ( VideoDriver && CreationParams.WindowSize.Width == 0 && CreationParams.WindowSize.Height == 0 && Width > 0 && Height > 0 )
	{
	#ifdef _IRR_EMSCRIPTEN_PLATFORM_
	SDL_CreateWindowAndRendererFixed(Width, Height, SDL_Flags, &Window, &Renderer);