minio/blake2b-simd

Benchmark comparison with Go stdlib

Opened this issue · 3 comments

agnivade commented

Hi,

Looking at the Go source code, it also has AVX2 support - https://github.com/golang/crypto/blob/master/blake2b/blake2bAVX2_amd64.s.

But the benchmarks here show considerable difference -
https://github.com/minio/blake2b-simd#avx2

I could not find the code which generates benchmarks for Go and this library. Are the benchmarks outdated ? Is there a reason to choose this library over the Go one ?

fwessels commented

The benchmarking code is in https://github.com/minio/blake2b-simd/blob/master/benchmarks_test.go.

Since we did the benchmark there have been development in Golang (stdlib) so, given some spare time, it would be good to redo the benchmarks.

agnivade commented

Please correct me if I am wrong, but that file just compares the different hash methods. It does not compare BLAKE2b Go vs this repo.

fwessels commented

You are correct, was a bit too quick there.

We will have modified these benchmark tests and captured the results in consecutieve runs in order to compare between old and new (and also avoid a naming clash by including two blake2b’s).

  • 👍1