miniscruff/changie

make lint error

Closed this issue · 3 comments

katerberg commented

Thanks for submitting a bug report, please fill in the following details.

Description

There is a linting error around the usage of .md constant.

Reproduction Steps

Steps to reproduce the behavior:

  1. Install go
  2. Install goimports
  3. Install other two required libraries
  4. Run make lint on main.
  5. See error

What happened

~/src/changie$ make lint
goimports -w -local github.com/miniscruff/changie .
golangci-lint run ./...
core/utils_test.go:285:54: string `.md` has 6 occurrences, make it a constant (goconst)
					&then.MockDirEntry{MockName: tc.latestVersion + ".md"},

Expected behavior

Clean linting command

Additional context

This is on a Mac and I installed everything from brew.

go version go1.21.3 darwin/arm64
go install golang.org/x/tools/cmd/goimports@latest

miniscruff commented

What version of golangci lint are you using?

katerberg commented

golangci-lint has version 1.55.2 built with go1.21.3 from e3c2265f on 2023-11-03T12:59:25Z

miniscruff commented

There must of been a config change or something in 1.55 but yea, it should be fixed now.

  • 👍1