mira-space/MiraData

[Bug] Small error in logging

Opened this issue · 2 comments

Hi thanks for releasing this dataset. The videos are really cool.

There is an error in logging, when some of the videos are deleted or changed to private, resulting errors like:

youtube_dl.utils.DownloadError: ERROR: Private video
Sign in if you've been granted access to this video

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/mnt/e/MiraData/download_data.py", line 61, in <module>
    logging.debug(f"Can not download video {key}, skip")
NameError: name 'key' is not defined

From my side, i modified the code in download_data.py

        except Exception as error:
            print(error)
            # logging.debug(f"Can not download video {key}, skip")
            # logging.debug(f"Try another time")
            fail_times+=1
            if fail_times==3:
                break

Also another issue, youtube dl from pip install does not work for me. If you face similiar error, consider to try:

pip install --upgrade --force-reinstall "git+https://github.com/ytdl-org/youtube-dl.git"

it helps, thanks!

thanks very mush!!!