Lwt_sequence is deprecated
djs55 opened this issue · 7 comments
A manual build (with --dev) fails with:
File "src/tcp/segment.ml", line 32, characters 8-31:
Error (warning 3): deprecated: module Lwt_sequence
This module is an implementation detail of Lwt. See
https://github.com/ocsigen/lwt/issues/361
Related to [ocsigen/lwt#361]
Any plan to fix it? I can take my time to try to fix it (needed to git-mirage).
@dinosaure I won't have time to fix this in the next couple of weeks and would welcome a PR addressing it.
Ok. I will make something when @samoht will confirm to me that is the source of bug 👍 .
@dinosaure may I know how you are planning to fix this issue. https://github.com/diml/lambda-term also needs to be updated to use a different doubly linked list. Will you be using a separate implementation of doubly linked list perhaps or per use Lwt_sequence with a different name?
According to what I said to @yomimono at the last hackathon, my goal is to provide a proved implementation of a double linked-list. I just discover in a paper than it's not possible to use Why3 in this case. So the plan is to use CFML/Coq instead. So, of course, this library will be outside mirage-tcpip and will be used in lambda-term too.
See also mirage/mirage#889 , the higher-level tracking issue for lwt 4.0.0 and mirage.