mirage/ocaml-cstruct

remove camlp4 dependency via ocplib-endian

Closed this issue · 4 comments

avsm commented

ocplib-endian depends on cppo which depends on camlp4.

I think we dont need the abstraction provided by ocplib-endian any more, as our minimum compiler version can safely be 4.02.3 upwards. Creating this issue to see how invasive that patch would be...

@avsm If you are seeing a camlp4 dep it must come from some where else:

> opam list --rec --required-by ocplib-endian -s
base-bytes
conf-m4
cppo
ocamlbuild
ocamlfind

Sorry, I'm just a moron. I misread the cppo docs and thought it was camlp4 related, but it isn't. I mentioned this to Anil, and so the mistake is mine.

avsm commented

Weird, I also checked it before creating the issue and thought that cppo used camlp4. I guess I was confusing it with optcomp, which older ocplib-endian uses. If you had an older version of ocplib-endian pulled in due to a constraint, you might have seen camlp4 @yminsky