mirage/ocaml-github

Install issue on osx in 4.03 switch

Closed this issue · 11 comments

Compilation seems to hang on:

/Users/dbuenzli/.opam/4.03.0/bin/ocamlfind ocamlc -c -g -annot -bin-annot -principal -strict-sequence -I lib -I unix -I js -package atdgen -package bytes -package cmdliner -package cohttp -package cohttp.js -package cohttp.lwt -package cohttp.lwt-core -package js_of_ocaml -syntax camlp4o -package js_of_ocaml.syntax -package lwt -syntax camlp4o -package lwt.syntax -package lwt.unix -package stringext -package uri -package yojson -w @5@8@10@11@12@14@23@24@26@29 -I lib_test -I js -I lib -I unix -o lib_test/test_javascript.cmo lib_test/test_javascript.ml

Here's what was reported when I killed the thing:

E: Failure("Command ''/Users/dbuenzli/.opam/4.03.0/bin/ocamlbuild' lib/github_core.cma lib/github_core.cmxa lib/github_core.a lib/github_core.cmxs unix/github_unix.cma unix/github_unix.cmxa unix/github_unix.a unix/github_unix.cmxs js/github_js.cma js/github_js.cmxa js/github_js.a js/github_js.cmxs jar/jar.native jar/create_release.native jar/sync_releases.native jar/upload_release.native jar/list_releases.native jar/list_events.native jar/list_issues.native jar/search.native jar/listen_events.native gist/gist.native lib_test/current_user.native lib_test/get_token.native lib_test/repo_info.native lib_test/issues.native lib_test/tags.native lib_test/milestones.native lib_test/releases.native lib_test/deploy_keys.native lib_test/pulls.native lib_test/create_issue.native lib_test/create_milestone.native lib_test/create_pull.native lib_test/create_hook.native lib_test/delete_all_hooks.native lib_test/create_statuses.native lib_test/organizations.native lib_test/parse_events.native lib_test/test_javascript.byte -tag debug' terminated with error code 100")
avsm commented

Hm, memory problems?

Hm, memory problems?

WDYM ? This is on my usual machine (also it seems to be tests why does the package build them ?).

Could it be an old version? I remember fixing the test building issue. I just checked master again and no tests are built.

No this happens while trying to install 1.0.0.

Actually, looks like my commit didn't make it into 1.0.0:

5eb03f9

Would you mind pinning master and reporting the result?

That worked.

For the record, I was getting the same issue on debian and netbsd. The problem seems to be when js_of_ocaml is installed. Running opam install github -v I see the build hang at:

ocamlfind ocamlc -c -g -annot -bin-annot -principal -strict-sequence -I lib -I unix -I js -package atdgen -package bytes -package cmdliner -package cohttp -package cohttp.js -package cohttp.lwt -package cohttp.lwt-core -package js_of_ocaml -syntax camlp4o -package js_of_ocaml.syntax -package lwt -syntax camlp4o -package lwt.syntax -package lwt.unix -package stringext -package uri -package yojson -w @5@8@10@11@12@14@23@24@26@29 -I lib_test -I js -I lib -I unix -o lib_test/test_javascript.cmo lib_test/test_javascript.ml

At that point, ocamlc-opt proceeds to eat up all the memory available and eventually the build fails. Pinning to --dev-repo also worked for me to get it successfully installed.

Would it be possible to make a release to fix this ? It has been twenty days and you are a dependency of opam-publish. This affects anyone wanting to publish OPAM packages using this tool.

Is this not fixed in 1.1.0?

Ah yes sorry got caught again about unpinning resulting in the installation of the previous version. Btw. it's also a good idea to close issues once they are resolved.