discoverEmberDataModels() fails if any pre Octane style Ember model has a property named `errors`

Question

discoverEmberDataModels() fails if any pre Octane style Ember model has a property named `errors`

andrew-paterson opened this issue a year ago · 1 comments

Using Ember data 3.28.0 and Ember CLI Mirage 2.4.0.

If your model is defined in the non class-based syntax, and it has a property names errros, then this line models: { ...discoverEmberDataModels(), ...config.models }, in mirage/config.js throws an error because the discoverEmberDataModels function throws an error.

Updating the model in question to the class-based syntax resolves the issue.

Answer 1 · 2023-10-04T00:19:56.000Z

@andrew-paterson given the whole ecosystem moves to "just use the platform", native classes have been available for a long time and as you described using there is a super simple way to fix this, I don't think we should do anything in this addon.