mislav/will_paginate

Default view labels broken from 3.1.3

Closed this issue · 4 comments

richhollis commented

Hi

First, thanks for a great project!

I recently noticed that the previous and next labels in one of my projects changed from their arrows and correct labels to saying "Previous Label" and "Next Label" (the symbols).

Tracing back, I found that the problem is introduced in 3.1.3. There are some I18n changes (c8361be and a3df0ae) in there so I wonder if anything stands out to you.

If I manually add the labels to my en.yml file then they do start working again, so it's like will_paginate just can't locate it's own default labels.

This is with a Rails 3.2.22.x project in case that's a factor. I'll revert to 3.1.2 for the time being.

Let me know if I can help at all.

Thanks!

richhollis commented

I'm going to close this issue because IMHO the better fix is to upgrade to Rails 4+. This issue is not present in 4.0.

toncid commented

This is reproducible in Rails v4.2.7, so it's not caused by Rails.

richhollis commented

That's strange! I've just tested it again in 4.x (4.0.13 effective) and it is working OK with the latest version 3.1.5. I will be upgrading to 4.2 shortly so I will see what happens when I get there and report back.

CharlieIGG commented

Having the exact same issue using Rails 5.0.4

EDIT - I realized I didn't have the proper translations in my i18N files. While this might be a "no duh" case, it might be nice to have some reference to this page in the main README: https://github.com/mislav/will_paginate/wiki/I18n