misoproject/dataset

require.js with miso dataset 0.2.1

pwistrand opened this issue · 2 comments

I'm trying to get miso dataset working with require.js. has anyone successfully done this? I've having difficulty as while Miso is defined Miso.Dataset is not.

require.config({
paths: {
jquery: 'lib/jquery',
knockout: 'lib/knockout',
domReady: 'lib/domReady',
misoDataset: 'lib/miso.ds.deps.min.0.2.1'
}
});

require(['knockout', 'jquery', 'misoDataset', 'appViewModel', 'customHandlers', 'domReady!'], function(ko, $, Miso, appViewModel) {

var ds = new Miso.Dataset({
iros commented

We'll add require support in the next version.
Thanks for reporting the issue.

iros commented

Fixed in pull req above