Add '--always' to vcs_tag in meson.build
ComfyKernel opened this issue · 3 comments
ComfyKernel commented
Without it there is a chance that the build will fail because git couldn't generate a full version name.
change
> ['git', 'describe' '--dirty=+']
to
> ['git', 'describe', '--always', '--dirty=+']
misyltoad commented
Hi, I actually didn't write this, I adapted dxvk's build scripts.
Is there a reason why this only affects dxup and the same doesn't apply to dxvk?
(dxvk: https://github.com/doitsujin/dxvk)
ComfyKernel commented
It's possible this also affects DXVK, I just haven't had the need to build it in a long time since it's distributed on steam and in winetricks
misyltoad commented
Looked into this more, added it.
Seems like it's needed when nothing is tagged.
Cheers!
- Josh