mitchos/pyZscaler

[BUG]: create_token() is hardcoded to post only production URL 'https://config.private.zscaler.com/signin'

Closed this issue · 2 comments

Describe the bug

The def create_token() under class AuthenticatedSessionAPI in \pyzscaler\zpa\session.py returns a post statement that is hardcoded to
'https://config.private.zscaler.com/signin' today . This fails if we use non-prod (beta/override_url)

To Reproduce
Steps to reproduce the behavior:

If we use cloud='beta' while creating ZPA object, it fails during authentication because the session token is still pointing to prod URL.

def _get_zpa_obj():
# create a ZPA object
# this ZPA object stores the session token and simplifies access to API interfaces within ZPA
# use cloud= beta or cloud = production for respective enviroment
return ZPA(client_id=CLIENT_ID,
client_secret=CLIENT_SECRET,
customer_id=CUSTOMER_ID,
cloud='beta')

Expected behavior

def create_token() should accept another argument that is dynamic based on environment chosen (prod/beta/override_url)

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows
  • Visual Studio

Additional context

Add any other context about the problem here.

Thanks for raising @rakbarkur

This is a simple fix as you've highlighted, so I'll slot this one into the next release, I'm just finishing some work on #160 and #175 and then I'll release them all together.

Thank you @mitchos.