mitmath/computational-thinking

hw1 quantize check

zmoon opened this issue · 1 comments

zmoon commented

I feel like the check might be inadequate?

https://github.com/mitmath/18S191/blob/123040947d5b03a572b58c261b3009c8041b5c4e/homework/homework1/hw1.jl#L986-L1000

Since it is checking 0.3, floor with any digits ≥ 1 will pass, when really we want digits=1.

fonsp commented

Yep! Feel free to open a PR