Podcast frontpage notifications are inaccurate
Closed this issue · 2 comments
We've seen some email notifications go out that include really old (10+ years) podcast episodes in them. It looks like the current logic sorts by created_on
rather than last_modified
(which corresponds to pubDate
in the feed xml). Additionally, it is returning all podcasts, including ones that aren't published anymore.
- Update the logic to sort by
last_modifed
instead ofcreated_on
- Update logic to filter to
published=True
@rhysyngsun to make sure I understand the logic/ask on the filtering - you mention the sorting by created - should it also filter episodes = episodes.filter(last_modified__gt=notification.created_on)
instead of episodes = episodes.filter(created_on__gt=notification.created_on)
as well? If we want all created, despite date, I'll leave it, but it seemed like a logical change as well, but wasn't quite in line with the other two asks.
@JenniWhitman yes that makes sense