Why does Fragile only panic on drop if `std::mem::needs_drop::<T>()` is true?

Question

Why does Fragile only panic on drop if `std::mem::needs_drop::<T>()` is true?

Closed this issue 3 years ago · 2 comments

An alternative might be to always ensure that the drop is occurring on the right thread, as a way to provide a guard rail against incorrect use of the API.

This question came up while reviewing the crate for vendoring, relaying here.

Answer 1 · 2022-01-15T22:11:16.000Z

@anp do you see a situation where it would be beneficial for a drop to be forced to the right thread? The main reason I decided on this is that you can have a non send type that doesn't have a dtor at all in which case that is an unnecessary restriction that doesn't help much.

Answer 2 · 2022-03-27T03:48:20.000Z

Closing this due to lack of activity.