mitsuhiko/sha1-smol

Why are PartialOrd, PartialEq, Ord, Eq not implemented?

matthiasbeyer opened this issue · 4 comments

matthiasbeyer commented

Hi,

why are these traits are not implemented for the Sha1 or Digest types?

mitsuhiko commented

I don't think there is a good reason. Could be added.

  • 👍1
matthiasbeyer commented

I'd love to submit a PR, maybe today evening!

mitsuhiko commented

Would be cool!

  • 👍1
matthiasbeyer commented

Well... now I know! We cannot derive them because [u8; 64] does not allow deriving them.

I could implement this, although I'm not sure I'd be able to implement a fast algorithm here.