mitsuhiko/sha1-smol

Warnings from sha1 0.6.0 using rustc 1.28.0

ry opened this issue · 0 comments

ry commented
[104/188] ACTION //build_extra/rust:sha1_rustc(//build/toolchain/mac:clang_x64)
warning: unnecessary parentheses around method argument
   --> ../../third_party/rust_crates/registry/src/github.com-1ecc6299db9ec823/sha1-0.6.0/src/lib.rs:311:41
    |
311 |         ($a:expr, $b:expr, $c:expr) => (($c ^ ($a & ($b ^ $c))))
    |                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
...
314 |     e = e.wrapping_add(a.rotate_left(5)).wrapping_add(bool3ary_202!(b, c, d)).wrapping_add(t);
    |                                                       ---------------------- in this macro invocation
    |
    = note: #[warn(unused_parens)] on by default

warning: unnecessary parentheses around method argument
   --> ../../third_party/rust_crates/registry/src/github.com-1ecc6299db9ec823/sha1-0.6.0/src/lib.rs:311:41
    |
311 |         ($a:expr, $b:expr, $c:expr) => (($c ^ ($a & ($b ^ $c))))
    |                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
...
317 |     d = d.wrapping_add(e.rotate_left(5)).wrapping_add(bool3ary_202!(a, b, c)).wrapping_add(u);
    |                                                       ---------------------- in this macro invocation

warning: unnecessary parentheses around method argument
   --> ../../third_party/rust_crates/registry/src/github.com-1ecc6299db9ec823/sha1-0.6.0/src/lib.rs:311:41
    |
311 |         ($a:expr, $b:expr, $c:expr) => (($c ^ ($a & ($b ^ $c))))
    |                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
...
320 |     c = c.wrapping_add(d.rotate_left(5)).wrapping_add(bool3ary_202!(e, a, b)).wrapping_add(v);
    |                                                       ---------------------- in this macro invocation

warning: unnecessary parentheses around method argument
   --> ../../third_party/rust_crates/registry/src/github.com-1ecc6299db9ec823/sha1-0.6.0/src/lib.rs:311:41
    |
311 |         ($a:expr, $b:expr, $c:expr) => (($c ^ ($a & ($b ^ $c))))
    |                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
...
323 |     b = b.wrapping_add(c.rotate_left(5)).wrapping_add(bool3ary_202!(d, e, a)).wrapping_add(w);
    |                                                       ---------------------- in this macro invocation

warning: unnecessary parentheses around method argument
   --> ../../third_party/rust_crates/registry/src/github.com-1ecc6299db9ec823/sha1-0.6.0/src/lib.rs:336:41
    |
336 |         ($a:expr, $b:expr, $c:expr) => (($a ^ $b ^ $c))
    |                                         ^^^^^^^^^^^^^^ help: remove these parentheses
...
339 |     e = e.wrapping_add(a.rotate_left(5)).wrapping_add(bool3ary_150!(b, c, d)).wrapping_add(t);
    |                                                       ---------------------- in this macro invocation

warning: unnecessary parentheses around method argument
   --> ../../third_party/rust_crates/registry/src/github.com-1ecc6299db9ec823/sha1-0.6.0/src/lib.rs:336:41
    |
336 |         ($a:expr, $b:expr, $c:expr) => (($a ^ $b ^ $c))
    |                                         ^^^^^^^^^^^^^^ help: remove these parentheses
...
342 |     d = d.wrapping_add(e.rotate_left(5)).wrapping_add(bool3ary_150!(a, b, c)).wrapping_add(u);
    |                                                       ---------------------- in this macro invocation

warning: unnecessary parentheses around method argument
   --> ../../third_party/rust_crates/registry/src/github.com-1ecc6299db9ec823/sha1-0.6.0/src/lib.rs:336:41
    |
336 |         ($a:expr, $b:expr, $c:expr) => (($a ^ $b ^ $c))
    |                                         ^^^^^^^^^^^^^^ help: remove these parentheses
...
345 |     c = c.wrapping_add(d.rotate_left(5)).wrapping_add(bool3ary_150!(e, a, b)).wrapping_add(v);
    |                                                       ---------------------- in this macro invocation

warning: unnecessary parentheses around method argument
   --> ../../third_party/rust_crates/registry/src/github.com-1ecc6299db9ec823/sha1-0.6.0/src/lib.rs:336:41
    |
336 |         ($a:expr, $b:expr, $c:expr) => (($a ^ $b ^ $c))
    |                                         ^^^^^^^^^^^^^^ help: remove these parentheses
...
348 |     b = b.wrapping_add(c.rotate_left(5)).wrapping_add(bool3ary_150!(d, e, a)).wrapping_add(w);
    |                                                       ---------------------- in this macro invocation