miyagawa/Twiggy

t/disconnect.t fails on 5.10.1

Opened this issue · 5 comments

Test named "got empty response to incomplete header request" from t/disconnect.t fails on perl 5.10.1 http://tinyurl.com/7bm68z2

I also get a failure on 5.10.1
I asked on irc.perl.org#plack
If I output $data before the failing test I get:

t/disconnect.t ................ 
ok 1 - got empty response to empty request
data=<HTTP/1.0 400 Bad Request
Content-Type: text/plain

>
not ok 2 - got empty response to incomplete header request

1..2
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests 

Twiggy 0.1020

This test is wrong by nature. It simulates close with shutdown on write.

Is it safe to assume this test is broken and skip it if it fails on 5.10.1?

pjfl commented

If this isn't going to be fixed (and it's now 2 years old) you should raise the minimum required Perl version above 5.10.1 to signal a lack of support. At least that way people won't see it as module that just fails to install

I created a patch and confirmed t/disconnect.t passed on Strawberry Perl 5.10.1(Windows 7 32bit).
However, I think that someone can make a better patch.

Twiggy-0.1025.gh-27.patch.txt