mjavascript/practical-modern-javascript

Screenshot of ESLint output seems a bit outdated

vsemozhetbyt opened this issue · 2 comments

vsemozhetbyt commented

See https://github.com/mjavascript/practical-modern-javascript/blob/master/ch01.asciidoc#fig0102 and the previous code.

Currently, I get this output:

Code: 
  1:12  error  Infix operators must be spaced                                                                                 space-infix-ops
  3:10  error  'hello' is defined but never used                                                                              no-unused-vars
  3:15  error  Missing space before function parentheses                                                                      space-before-function-paren
  3:17  error  Missing space before opening brace                                                                             space-before-blocks
  4:17  error  Requires a space before '}'                                                                                    block-spacing
  4:17  error  Closing curly brace should be on the same line as opening curly brace or on the line after the previous block  brace-style
  6:1   error  Expected space(s) after "if"                                                                                   keyword-spacing
  6:4   error  Unexpected constant condition                                                                                  no-constant-condition
  6:10  error  Missing space before opening brace                                                                             space-before-blocks

✖ 9 problems (9 errors, 0 warnings)
  7 errors, 0 warnings potentially fixable with the `--fix` option.�

Maybe at least the line about extra semicolon can be deleted from the screenshot as most confusing (there is no semicolon in the code).

bevacqua commented

Would you make a PR with Hyper and the snazzy theme?

vsemozhetbyt commented

Sorry, I do not have Hyper and never used it.

  • 😄1