mkrl/ttty

History keyboard traveling is inconsistent

mkrl opened this issue · 1 comments

mkrl commented

Describe the bug

Sometimes you can slip into the "undefined" territory when searching the command history with a keyboard. Also, the "down" history navigation would be nice to have

Steps to reproduce

Steps to reproduce the behavior:

  1. Open up the terminal
  2. Without typing any commands, press "up"
  3. See "undefined" show up in the terminal

Also, when navigating with the "down" arrow:

  1. Open up the terminal
  2. Type several commands
  3. Travel up the history and then down. It only works after pressing the "down" several times and is not consistent.

Expected behavior

Navigating the history when the history is empty should not print anything in the terminal.
Navigating down should be instant and should seamlessly scroll the history down.

ttty version

1.0.0

Additional context

A good place to start is here:

ttty/src/helpers/history.ts

Line 16 in a732215

export const searchHistory = (instance: Terminal, isDown?: boolean) => {

github-actions commented

🎉 This issue has been resolved in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀