Implement `get` and `delete` in the S3 driver

Question

Implement `get` and `delete` in the S3 driver

Closed this issue 4 years ago · 6 comments

Answer 1 · 2019-09-25T11:01:43.000Z

I spent quite some time trying to figure out why I got an empty response for my file before I realised that this very essential feature is not implemented. The library returns empty data, even though it's documented as working. Maybe consider throwing a fatalError or similar to not mislead consumers of the API.

Answer 2 · 2019-10-21T09:03:59.000Z

@kasperwelner Sorry about that! I've addressed it in #64

Answer 3 · 2019-11-27T07:53:14.000Z

Hi! I have an implementation of the get function that I'm willing to create a pull request for if you want it :)

Answer 4 · 2019-12-01T13:14:49.000Z

@MattiasBowallius PRs are very welcome! 😃

Answer 5 · 2019-12-05T09:38:53.000Z

Unfortunately I don't have enough access rights to create a branch and therefore a PR :)

Answer 6 · 2019-12-12T14:15:46.000Z

@MattiasBowallius Ah, the way to get around that is to fork it and create PR, a new branch there and then PR from there into this repo 🙂