isOptional false precludes other validators

Question

isOptional false precludes other validators

Closed this issue 6 years ago · 3 comments

https://github.com/nodes-vapor/submissions/blob/69ca301fa0f7b532e9acf410e8e825e40be206b3/Sources/Submissions/Field.swift#L30-L32

Looking at that, it appears that if I say isOptional = false then the only validator that will run is the errorOnNil one

Answer 1 · 2018-05-29T05:41:22.000Z

I plan to write tests for this but the way I intended it is that I return the errorOnNil, when there is:

no value (.none),
when .createing a new instance
where isOptional == false

I believe that is correct.

Answer 2 · 2018-05-29T13:44:07.000Z

Why wouldn’t the other validations run when creating a new instance?

…

On May 28, 2018, at 10:41 PM, Siemen Sikkema ***@***.***> wrote: I plan to write tests for this but the way I intended it is that I return the errorOnNil, when there is: no value (.none), when .createing a new instance where isOptional == false I believe that is correct. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Answer 3 · 2018-05-29T13:48:28.000Z

A Field supports multiple validators that take a non-optional value. So they can only be run when there is an actual value. Keep in mind that the validators of the other fields will still be run!