[Bug]: return value from sentiment.predict() is outdated information
Closed this issue · 2 comments
Issue Type
Other
Link to the issue
https://docs.ml5js.org/#/reference/sentiment?id=sentimentpredict
Issue description
Hi!! ml5 team :)
Currently, the sentiment.predict() method in the reference returns {score: 0.9999948740005493} , but in the latest version, it returns a value like {confidence: 0.9999948740005493} . I believe this discrepancy is due to outdated information from version v0.12.2.
For reference, I have provided the relevant source code below:
- reference: https://github.com/ml5js/ml5-website-v02-docsify/blob/main/docs/reference/sentiment.md?plain=1#L281
- v0.12.2: https://github.com/ml5js/ml5-library/blob/main/src/Sentiment/index.js#L117
- v1: https://github.com/ml5js/ml5-next-gen/blob/main/src/Sentiment/index.js#L142
I am considering submitting a pull request to update this reference.
Would that be okay?
I’m still a beginner at contributing to open source software, but I would like to contribute to the development.
Thank you!
Code of Conduct
- I agree to follow this project's Code of Conduct
Hi Miu! Of course, you’re welcome to submit a PR to fix this issue. Would you please do that as soon as possible?
@alanvww
Hi Alan! Thank you for your quick response.
I've just submitted a PR, so please take a look when you have a moment :)