Issue with no-shadow-restricted-names ESLint rule
skylarmb opened this issue · 1 comments
skylarmb commented
Using the wrap: true option results in the module being wrapped in
(function(angular, undefined) {
...
})(angular);
Passing undefined as an argument conflicts with best practices and the no-shadow-restricted-names rule in ESLint. This should not be the default behavior of wrap: true in my opinion.
https://eslint.org/docs/rules/no-shadow-restricted-names
A workaround for now is defining my own wrap function.
mlegenhausen commented
In generell I would not recommend to lint auto generated files, but this is another story.
What you do is the way to go, for everything that does not fit your needs.
Changing the wrapper could lead to other problems for other users. If I will release a version 3 of this task I would totally agree this is the way to go.