Using a more specific check instead of indexOf('value')

Question

Using a more specific check instead of indexOf('value')

Opened this issue 4 years ago · 4 comments

Please use a more specific check instead of indexOf('value')

It's necessary to avoid false positives on CSS like: [data-value='0']

Answer 1 · 2021-01-19T23:14:21.000Z

I'll need to think about this one, as it's probably an edge case. Do you have a site that triggers a false positive from rules like this?

Answer 2 · 2021-01-20T07:55:29.000Z

Do you have a site that triggers a false positive from rules like this?

https://yandex.ru/search/?text=майнкрафт&lr=2

Answer 3 · 2021-01-20T14:11:28.000Z

Thanks! Can confirm it triggers the plugin. Not sure what to do about it yet though without impacting filtering elsewhere. It may be possible to look for indexOf(' value') instead of indexOf('value'), but this may cause it to ignore cases where it shouldn't.

Answer 4 · 2021-01-25T19:34:32.000Z

Had an idea on this. It might be better to instead ignore rules where the string "-value" is found, which would filter out things like "data-value" selectors.