onStop event is not emitted
mc-mosa opened this issue · 7 comments
The onStop event is not emitted when the countdown is stopped
I am using this library on a project and I noticed that calling the stopCountdown() method stops the countdown. When I start the countdown again, the time passed is taken into account
This is observable also in the demo page https://vac.js.org/examples/methods/all-methods.html.
Just click on stop, wait for some time, and click start again.
I could just not render the component as a work around, e.g. v-if="isCounting" instead of using the stopCountdown() method
Is the issue I mentioned related to this event not being emitted? And is it expected for the fix to be merged?
No this doesn't have anything to do with the problem you mentioned.
I have noticed it as well but don't have much time to look into it at the moment. I don't know if that's an intended behavior or just a bug. Will try to look into it as soon as I have the time.
Doesn't seem to me like an intended behavior. Thank you for that, I will keep my 👀 open for this one
Merged
Hey, I saw that you merged a fix this morning. I have updated the library and the bug is still happening, that's also true for the live example that I mentioned before https://vac.js.org/examples/methods/all-methods.html . Am I missing something?
Hey, sorry.. the merge was for the bug mentioned in the title of this issue. I haven't got the chance to look into the bug we discussed earlier, will try to do that this weekend.