mlochbaum/CrinGraph

Removing line limitation when reading files.

Opened this issue · 1 comments

I have been testing the graph tool for a while, and find out that I the rawChannels array cannot take more than 480 elements for each channel, thus created a problem like this
image

File used
Starfield L.txt
Starfield R.txt

Not sure what is the issue though. Since #loadFiles() seems to work like intended.

Edit: After a while, I found out it is due to the config.js only parse from line 2 to line 482 might cause the problem. Issue renamed to make a propose instead

Hi Banbeu!

I don't consider config.js to be part of the tool, really. It's included to make the sample graph tool work and for convenience when working with Crin (but he doesn't use the one directly from the repository any more). So it's expected that you will make some changes.

I don't know whether there's a good way to detect the number of samples in general, since there can be trailing lines. If you know more about the kind of file format I can expect, then I could take your suggestion.

Parts of the tool like smoothing and labelling depend on the graphs all being based on the same set of frequencies. If you want to use graphs that have different numbers of samples then I'll have to fix these.