mlr-org/ParamHelpers

make*Param: assert for len

Closed this issue 8 years ago · 5 comments

berndbischl commented 8 years ago

this is missing
we need this for normal params and vec params

berndbischl commented 8 years ago

and sometimes uninformative errors are produced

berndbischl commented 8 years ago

also check that for normal param lengths can then not be set to NA

berndbischl commented 8 years ago

normal violations are checked now

makeNumericVectorLearnerParam("x", len = "aa")

Assertion failed. One of the following must apply:

checkCount(len): Must be of type 'count', not 'character'
checkClass(len): Must have class 'expression', but has class 'character'

berndbischl commented 8 years ago

also check that for normal param lengths can then not be set to NA

unit tested this now

berndbischl commented 8 years ago

more problems i cannot see now, closing