mlr-org/mlr3hyperband

code review mb706

Closed this issue · 4 comments

mb706 commented

click on the '<' at the upper right if you don't see the comments

SebGGruber commented

does mlr3hyperband modify the mlr3 logger? If yes, this is bad. If no, this sentence should be "The default logging threshold of the mlr3 logger is warn" and put in parentheses.

How else should I disable info messages of mlr3 calls in the background?
I don't know why, but last time when I didn't set the threshold to "warn", I had cluttered info messages. I did another run today with a new R session without setting the threshold and suddenly the cluttered info logs are gone. I guess I just do, what you said and remove the threshold setting of mlr3 as it is obviously not required. But my first question still holds out of curiosity.

SebGGruber commented

btw, I implemented your review suggestions in my dev branch

juliambr commented

Martin's remark about the rounding errors goes into a new issue #57; apart from that, it can be closed.