mmikkel/Retcon-Craft

Issue of Default Size of Height in srcset function

Closed this issue · 1 comments

bharat303 commented

In commit : 8556999
You have set default value of $height to 11 instead of 1 by mistake I think.

Current code is as following at line number around :

if ($base64src) {
    $node->setAttribute('src', RetconHelper::getBase64Pixel($width ?? 1, $height ?? 11));
}

Can you please set it to 1? This is creating serious issue for us as next content after inline image is loaded by animation, and due ratio of 1:11, it's showing blank as it's allocation huge pillar space due to 1:11

i.e. That should be like this by default values :
src="data:image/svg+xml;charset=utf-8,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 1 1'/>"

Instead of :
src="data:image/svg+xml;charset=utf-8,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 1 11'/>"
mmikkel commented

Thanks for reporting that! Fixed in Retcon v. 2.7.4.

  • 👍1