mmistakes/so-simple-theme

config.yml references default.css, not default.scss

engn33r opened this issue · 4 comments

engn33r commented

Motivation

The following line looks like a slight typo in the config.yml file, since the skins are .scss files, not .css:
skin: "/assets/css/skins/default.css"

Suggestion

Even though the default will be used regardless, this should probably be:
skin: "/assets/css/skins/default.scss"

with an .scss extension, not .css

mmistakes commented

If it’s changed to .scss it’ll 404 since Jekyll is converting the files to .css

.scss also won’t be read properly by this line in the head

https://github.com/mmistakes/so-simple-theme/blob/master/_includes/head.html#L27

mmistakes commented

In hindsight might have made more sense to abstract skin’s to names instead of paths to a file. default, light, etc.

Similar to what I do with my other theme.

https://mmistakes.github.io/minimal-mistakes/docs/configuration/#skin

engn33r commented

Ok works for me. I'm not encountering an error so I'll close this out